<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/475/">http://svn.reviewboard.kde.org/r/475/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 30th, 2009, 2:34 a.m., <b>Andreas Pakulat</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">So which applications would use this widget, besides the solid kcm's (I'm assuming the kcm's can share the widget without it being in kdelibs)?</pre>
</blockquote>
<p>On March 30th, 2009, 2:37 a.m., <b>Dario Freddi</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">At the moment none, but since Solid is growing, some applications could (in the future) provide a backend selector directly in their configuration panel. And it allows a single entry point to let the user modify backends in a consistent way. Since it's not a big overhead to kdeui, I think putting it there could be a sensible decision</pre>
</blockquote>
<p>On March 30th, 2009, 3:46 a.m., <b>Oswald Buddenhagen</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i hate to spoil the party ... but the 2+ users requirement exists not only to keep useless stuff out of the libs, but also to ensure API quality. as such, it would make sense if you ported any potential users to that api before pushing it.</pre>
</blockquote>
<p>On March 30th, 2009, 6:04 a.m., <b>Dario Freddi</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok, so basically you suggest to import this after the KCMs will be refactored? If so, I'll wait until then, I just wanted to know if, known the fact that the current hardware module will be splitted into the relevant modules (Power Management, Networking, etc), so definitely 2+ users, this patch should go in. Making the widget shared between the various kcms would be an unneeded overhead in my opinion</pre>
</blockquote>
<p>On March 30th, 2009, 6:17 a.m., <b>Andreas Pakulat</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">We suggest that there should be at least 2 different users of this widget before it goes into kdelibs. And I'm not sure wether multiple kcm's living in the same place in svn counts as multiple users of the class. The reason to move it to kdelibs should be that apps that cannot easily share such classes because they're in different modules don't have to keep their own copy. And a couple of kcm's inside kdebase can share the code by simply having that class in a common directory and each kcm compiling it into the plugin.</pre>
</blockquote>
<p>On March 30th, 2009, 6:22 a.m., <b>Dario Freddi</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok, I'll wait until our design on the new structure will be final. If kcmodules will be able to share the library, I'll simply discard this review and put the widget in kdebase, otherwise I'll bring the discussion back.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Has this idea been discarded for now? If so, the review should be closed.</pre>
<br />
<p>- Alex</p>
<br />
<p>On March 30th, 2009, 2:27 a.m., Dario Freddi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Dario Freddi.</div>
<p style="color: grey;"><i>Updated March 30, 2009, 2:27 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds a new widget to KDEUI, SolidBackendChooser. It is nothing but the widget now present in the Hardware KCM, updated with API Docs, a slightly better API and with all the nice things to help Binary Compatibility. It will be used for the refactoring of the new Solid kcmodules</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works in my copy</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdelibs/kdeui/CMakeLists.txt <span style="color: grey">(946126)</span></li>
<li>/trunk/KDE/kdelibs/kdeui/widgets/solidbackendchooser.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdelibs/kdeui/widgets/solidbackendchooser.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdelibs/kdeui/widgets/solidbackendchooser.ui <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/475/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>