<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100700/">http://git.reviewboard.kde.org/r/100700/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Runtime, Phonon, Phonon Backends, Harald Sitter, and Trever Fischer.</div>
<div>By Casian Andrei.</div>
<p style="color: grey;"><i>Updated Feb. 21, 2011, 11:23 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove trailing spaces...
Seems kdevelop doesn't mark them for me anymore :(</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Modifications on findVirtualDevices in PhononServer, to make it find usable capture devices for Phonon-VLC, at least. Phonon audio capture works with the provided devices. Also made a couple of mostly irelevant improvements.
The Phonon KDED module was not providing any usable capture devices. Only some iec958 digital devices showed up, which didn't work at all. VLC needs a default analog ALSA device, like hw:CARD=SB, in my case.
Solid is not returning any audio devices on my system. I do not know if it works properly on other systems, but I will investigate further.
This is the commit message:
Phonon KDED module: Improve finding virtual devices from ALSA
PhononServer was not finding any usable capture devices. It
was skipping almost all useful devices. Commented out the
block for skipping those.
Prevent devices with empty names when their description
is empty. This should not happen, but it's just in case.
Eliminate any front, center, rear, surround virtual devices from
capture device candidates.
Additionaly, there will be only one device with an unique id, with
one or more access descriptors.
Replace default: with hw: for capture devices, to enable capture
working with Phonon-VLC.
Because Solid doesn't give me any audio devices, I cannot test for the cases when it actually works. However, I believe that it doesn't work on most systems.
The other iec958 digital stuff devices show up as advanced.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Restarted KDED and ran kcmshell4 phonon, viewed the audio devices. All looks ok. No bogus devices.
Tested the capture demos from Phonon (currently they have a buggy interface, will be fixed), and they worked fine. Audio capture works ok with the Phonon-VLC backend. Audio-video capture also works if you get around the demo's interface bugs.
Don't know what happens when Solid actually works for audio devices, if these changes interfere with Phonon's functionality in that case.
Not tested on other systems to see if any bogus devices appear out of nowhere.
Amarok still works :P</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>phonon/kded-module/phononserver.cpp <span style="color: grey">(44f857e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100700/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/100700/s/79/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/02/21/skelet-capture1_400x100.png" style="border: 1px black solid;" alt="Capture devices in Phonon config" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>