<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6332/">http://svn.reviewboard.kde.org/r/6332/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If no one objects, I would like to commit this patch at the end of next week.</pre>
<br />
<p>- Martin</p>
<br />
<p>On January 15th, 2011, 9:37 a.m., Martin Engelmann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Martin Engelmann.</div>
<p style="color: grey;"><i>Updated Jan. 15, 2011, 9:37 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As stated in the bug report, the image on the folder preview should be enlarged if there is only one image.
To achieve this there are two images created for the folder: "img" as before and "oneTileImg". "oneTileImg" starts with the same image as "img", but after the first thumbnail is generated "oneTileImg" won't be touched. The number of successfully created thumbnails is counted in "validThumbnails". If only one thumbnail could be generated, "oneTileImg" is returned.
The code between lines 566 and 589 in the original thumbnail.cpp was partly extracted into a new function called "drawSubThumbnail". This is done to simplify the creation of the second preview.
The extra effort to create the "oneTileImg" comparable to creating a fifth preview image for the folder.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested using both Dolphin and Konqueror from trunk.
The thumbnail generation was tested by moving images and files without thumbnail plug-in to a new folder. Then one file after another was deleted until only files without thumbnail plug-in were present.
Also I opened randomly some folders with sub-folders containing large amounts of images (e.g. oxygen icon set with > 550 action icons) to the performance.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=240861">240861</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdebase/runtime/kioslave/thumbnail/thumbnail.h <span style="color: grey">(1214477)</span></li>
<li>/trunk/KDE/kdebase/runtime/kioslave/thumbnail/thumbnail.cpp <span style="color: grey">(1214477)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6332/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://svn.reviewboard.kde.org/r/6332/s/604/"><img src="http://svn.reviewboard.kde.org/media/uploaded/images/2011/01/15/kioslave-thumbnail-enlarge-single-thumbnailable-file_400x100.png" style="border: 1px black solid;" alt="Folder thumbnails for oxygen icon set in Konqueror" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>