<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6401/">http://svn.reviewboard.kde.org/r/6401/</a>
</td>
</tr>
</table>
<br />
<p>- Kevin</p>
<br />
<p>On January 25th, 2011, 9:30 a.m., Thomas Richard wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs, Kevin Ottens and Rafael Fernández López.</div>
<div>By Thomas Richard.</div>
<p style="color: grey;"><i>Updated Jan. 25, 2011, 9:30 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When a row other then the last got removed from a model, the widgets that are created by the itemdelegate are not moved. This is obviously a big problem when you start removing rows in between. The wrong widgets will show up in the wrong rows. This also happens when you insert a new row instead of appending it.
This patch will update the widgets position of the rows that come behind the one that is inserted/removed. I also had to change QModelIndex to QPersistentModelIndex at one place because the modelindex changes when your remove/insert a row in the middle and new widgets would get created.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">*Compiling
*Insert a row at the start/in the middle/at the end
*Remove a row at the start/in the middle/at the end
Everything seems to work now.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdelibs/kdeui/itemviews/kwidgetitemdelegate.h <span style="color: grey">(1216172)</span></li>
<li>trunk/KDE/kdelibs/kdeui/itemviews/kwidgetitemdelegate.cpp <span style="color: grey">(1216172)</span></li>
<li>trunk/KDE/kdelibs/kdeui/itemviews/kwidgetitemdelegate_p.h <span style="color: grey">(1216172)</span></li>
<li>trunk/KDE/kdelibs/kdeui/itemviews/kwidgetitemdelegatepool_p.h <span style="color: grey">(1216172)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6401/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>