<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6325/">http://svn.reviewboard.kde.org/r/6325/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The idea is OK. Two comments on the implementation, below.
Also, please note that the kdelibs coding style is "no spaces between (...)". Thanks.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://svn.reviewboard.kde.org/r/6325/diff/1/?file=44206#file44206line2310" style="color: black; font-weight: bold; text-decoration: underline;">trunk/KDE/kdelibs/kfile/kfilewidget.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KFileWidgetPrivate::updateLocationEditExtension (const QString &lastExtension)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">2310</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">urlStr</span> <span class="o">=</span> <span class="n">urlStr</span><span class="p">.</span><span class="n">mid</span><span class="p">(</span> <span class="n">urlStr</span><span class="p">.</span><span class="n">lastIndexOf</span><span class="p">(</span> <span class="n">KDIR_SEPARATOR</span> <span class="p">)</span> <span class="o">+</span> <span class="mi">1</span> <span class="p">);</span> <span class="c1">// only filename</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If you want a QString that holds a filename, please call it const QString fileName, rather than reuse urlStr to not contain a URL anymore :-)</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://svn.reviewboard.kde.org/r/6325/diff/1/?file=44206#file44206line2313" style="color: black; font-weight: bold; text-decoration: underline;">trunk/KDE/kdelibs/kfile/kfilewidget.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KFileWidgetPrivate::updateLocationEditExtension (const QString &lastExtension)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">2313</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span><span class="p">(</span> <span class="n">f</span><span class="p">.</span><span class="n">startsWith</span><span class="p">(</span> <span class="s">"*."</span> <span class="p">)</span> <span class="o">&&</span> <span class="n">urlStr</span><span class="p">.</span><span class="n">endsWith</span><span class="p">(</span> <span class="n">f</span><span class="p">.</span><span class="n">mid</span><span class="p">(</span> <span class="mi">1</span> <span class="p">)))</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This line could be more generic, using KMimeTypeRepository::matchFileName(fileName, f)
(that's in a private kdecore header, but the class is exported for kdelibs-internal usage). Then it would support other globs like Makefile.* etc.</pre>
</div>
<br />
<p>- David</p>
<br />
<p>On January 11th, 2011, 4:51 p.m., Lubos Lunak wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs, Rafael Fernández López and David Faure.</div>
<div>By Lubos Lunak.</div>
<p style="color: grey;"><i>Updated Jan. 11, 2011, 4:51 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Run e.g. Kolourpaint, do 'Save as', type 'a.xpm' , KFileDialog will automatically select 'XPM' as the saved type. This however doesn't work with all applications, namely those that use KFileDialog::setFilter() (i.e. only setMimeFilter() works this way). This patch implements this feature also for this case.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tried with LibreOffice with KDE4 integration, where this feature works only with this patch.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdelibs/kfile/kfilefiltercombo.h <span style="color: grey">(1208060)</span></li>
<li>trunk/KDE/kdelibs/kfile/kfilefiltercombo.cpp <span style="color: grey">(1208060)</span></li>
<li>trunk/KDE/kdelibs/kfile/kfilewidget.cpp <span style="color: grey">(1208060)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6325/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>