<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/4320/">http://svn.reviewboard.kde.org/r/4320/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Can you mark this review request as closed now that it's been committed?</pre>
<br />
<p>- Raphael</p>
<br />
<p>On December 28th, 2010, 1:39 a.m., Rodrigo Belem wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs, Raphael Kubo da Costa, Jonathan Thomas, Aurélien Gâteau, Jonathan Riddell, Adenilson Cavalcanti, loureiro, and Daniel Nicoletti.</div>
<div>By Rodrigo Belem.</div>
<p style="color: grey;"><i>Updated 2010-12-28 01:39:28</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KDE needs to support modern samba tools. With the "net usershare" command line tool the users can manage their shares. The attached patch intends to add support for this tool.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdelibs/includes/CMakeLists.txt <span style="color: grey">(1209617)</span></li>
<li>/trunk/KDE/kdelibs/includes/KSambaShareData <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdelibs/kio/CMakeLists.txt <span style="color: grey">(1209617)</span></li>
<li>/trunk/KDE/kdelibs/kio/kio/ksambashare.h <span style="color: grey">(1209617)</span></li>
<li>/trunk/KDE/kdelibs/kio/kio/ksambashare.cpp <span style="color: grey">(1209617)</span></li>
<li>/trunk/KDE/kdelibs/kio/kio/ksambashare_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdelibs/kio/kio/ksambasharedata.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdelibs/kio/kio/ksambasharedata.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdelibs/kio/kio/ksambasharedata_p.h <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/4320/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>