<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6192/">http://svn.reviewboard.kde.org/r/6192/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Teo Mrnjavac.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch removes the placeholder icons from the buttons that launch a person's social network profiles in the Social About dialog and fetches the needed icons from the OCS provider through Attica.
Currently 4.6 has only placeholders, so we definitely need to replace those with proper icons.
This has been made possible with a recent addition to the OCS API.
Most of the icons are trademarks so I believe it's best that we don't distribute them, and this seems like the cleanest solution, also because we have no use for those icons except for the Social About dialog anyway.
As for the implementation, I've created a job-like class which fetches the icons sequentially and caches them so we avoid fetching the same icons more than once.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested during and after coding with several OCS profiles.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/KDE/4.6/kdelibs/kdeui/dialogs/kaboutapplicationpersonmodel_p.h <span style="color: grey">(1208864)</span></li>
<li>/branches/KDE/4.6/kdelibs/kdeui/dialogs/kaboutapplicationpersonmodel_p.cpp <span style="color: grey">(1208864)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6192/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>