<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6177/">http://svn.reviewboard.kde.org/r/6177/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I know.
I think you misunderstood my reply.
Let me clarify: there are defaults, and defaults :-)
The "initial default" is the one that is used when the user has never tweaked any paths. That one comes from QDesktopServices.
The "restored default" is the one that the "Defaults" button sets as the new value. That one comes from the kcm, lines 142-148.
And my point is that these two "defaults" should match, otherwise things get very confusing: when the user presses the "Defaults" button he could get different folder names even if he/she didn't change any values ever! That's not the way people expect the "Defaults" button to work, it's suppose to restore "factory settings", aka "initial defaults".
How to make these two defaults match is tricky, given that QDesktopServices offers us no API for doing so. So one would need per-platform "reset" code. But at least the current code (with untranslated strings) matches the QDesktopServices "initial defaults" on X11, while your change makes things worse by making the initial and restored defaults not match on X11 anymore.</pre>
<br />
<p>- David</p>
<br />
<p>On December 21st, 2010, 2:18 p.m., Burkhard Lück wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs and David Faure.</div>
<div>By Burkhard Lück.</div>
<p style="color: grey;"><i>Updated 2010-12-21 14:18:35</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Using the Defaults button in the desktoppaths kcm resets all folders to the default values,
but is currently using the untranslated strings in branch and trunk.
Adding some i18n() calls resets the values to the translated strings for the folders.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/KDE/4.5/kdebase/workspace/kcontrol/desktoppaths/globalpaths.cpp <span style="color: grey">(1208322)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6177/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>