<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6111/">http://svn.reviewboard.kde.org/r/6111/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 14th, 2010, 12:59 p.m., <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The real question is whether this mimetype is used for files, or only for internal "fake" purposes. If for files, then it should be added to shared-mime-info (Pino or I can help with that).
But if I remember correctly in this case it's not about files, which is why a fake mimetype is used. In that case, I'd rather not reuse an existing file mimetype, but rather use a kde-specific fake name.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The mime definition in kde.xml seems to imply it's for real *.fonts.zip file globs. svn log kde.xml doesn't seem to include any mention of fonts/package origin though. :( (and I don't see anything in branches/KDE/3.5 either)</pre>
<br />
<p>- Rex</p>
<br />
<p>On December 13th, 2010, 5:07 p.m., Rex Dieter wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Rex Dieter.</div>
<p style="color: grey;"><i>Updated 2010-12-13 17:07:48</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adjusts the kde "fake" mimetype fonts/package so desktop-file-utils/shared-mime-info doesn't complain (using application/vnd.kde.fontspackage instead). Addresses bugs #235564, #250924</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">confirmed no warnings/errors from desktop-file-utils/shared-mime-info</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdebase/workspace/kcontrol/kfontinst/apps/kfontview.desktop <span style="color: grey">(1206154)</span></li>
<li>/trunk/KDE/kdelibs/mimetypes/kde.xml <span style="color: grey">(1206154)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6111/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>