<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5937/">http://svn.reviewboard.kde.org/r/5937/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 22nd, 2010, 9:10 p.m., <b>Christoph Feck</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Wouldn't it be much simpler to use a scaled QPainter on the QImage to render the filmstrip holes at different sizes?</pre>
</blockquote>
<p>On November 22nd, 2010, 9:32 p.m., <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">... besides that the (hard)code(d strips - at least form a glimpse on the diff) does not look endian safe - iff we still care about IBM/Motorola architectures (no idea what's required for bi-enders like ARM in this regard)</pre>
</blockquote>
<p>On December 5th, 2010, 10:29 p.m., <b>Andreas Scherf</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sure. The QPainter would be a better solution. But that would be the second step. This are the changes from the original project.
>From now on we could fork the code and implement our own filmstrip painting routines ...</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Could i commit the changes to trunk?</pre>
<br />
<p>- Andreas</p>
<br />
<p>On November 22nd, 2010, 8:16 p.m., Andreas Scherf wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Andreas Scherf.</div>
<p style="color: grey;"><i>Updated 2010-11-22 20:16:46</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">+ Some type changes (uinXX to quintXX), some code cleanup and some compile fixes.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdemultimedia/CMakeLists.txt <span style="color: grey">(1199813)</span></li>
<li>trunk/KDE/kdemultimedia/cmake/modules/FindFFMPEG.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdemultimedia/ffmpegthumbs/CMakeLists.txt <span style="color: grey">(1199813)</span></li>
<li>trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/ChangeLog <span style="color: grey">(1199813)</span></li>
<li>trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/filmstrip.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/filmstripfilter.cpp <span style="color: grey">(1199813)</span></li>
<li>trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/moviedecoder.h <span style="color: grey">(1199813)</span></li>
<li>trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/moviedecoder.cpp <span style="color: grey">(1199813)</span></li>
<li>trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/videoframe.h <span style="color: grey">(1199813)</span></li>
<li>trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/videothumbnailer.h <span style="color: grey">(1199813)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5937/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>