<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5885/">http://svn.reviewboard.kde.org/r/5885/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 17th, 2010, 11:25 a.m., <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good to me. Nice side effect, the error string as a wallet name :-)</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Committed to trunk and 4.5 branch, thank you.</pre>
<br />
<p>- Gökcen</p>
<br />
<p>On November 17th, 2010, 11:04 a.m., Gökcen Eraslan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs and David Faure.</div>
<div>By Gökcen Eraslan.</div>
<p style="color: grey;"><i>Updated 2010-11-17 11:04:26</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In KWallet::Wallet class (of kdelibs/kdeui/util/kwallet.cpp), validity of some DBus replies from kwalletd are not checked. Since kwallet clients like kwalletmanager do not check the validity of replies, client behave weird sometimes. For example if I disable kwallet and open kwalletmanager, I see a wallet named "The name org.kde.kwalletd was not provided by any .service files". Also another weird thing is that wallet seems open.
This patch add more validity checks to kwalletd dbus calls, to prevent weird behaviours of kwallet clients. This patch may also fix some bugs related to kwalletmanager or kwalletd.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with kwalletmanager of KDE 4.5.3, but patch is the same for trunk.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/kdeui/util/kwallet.cpp <span style="color: grey">(1198078)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5885/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://svn.reviewboard.kde.org/r/5885/s/558/"><img src="http://svn.reviewboard.kde.org/media/uploaded/images/2010/11/17/kwalletmgr-before_400x100.png" style="border: 1px black solid;" alt="Before" /></a>
<a href="http://svn.reviewboard.kde.org/r/5885/s/559/"><img src="http://svn.reviewboard.kde.org/media/uploaded/images/2010/11/17/kwalletmgr-after_400x100.png" style="border: 1px black solid;" alt="After" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>