<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5631/">http://svn.reviewboard.kde.org/r/5631/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 25th, 2010, 12:12 p.m., <b>Olivier Goffart</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://svn.reviewboard.kde.org/r/5631/diff/1/?file=39314#file39314line180" style="color: black; font-weight: bold; text-decoration: underline;">trunk/KDE/kdebase/runtime/knotify/knotify.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KNotify::reemit(int id, const ContextList& contexts)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">180</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">while</span> <span class="p">(</span><span class="n">actionsIterator</span><span class="p">.</span><span class="n">hasNext</span><span class="p">())</span><span class="ew"> </span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I do not really like this JavaStyle iterator. I think foreach would be better and more intuitive in that case.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I guess my concern using foreach was that this way we check the first element of the list twice, but that's not such a big deal after all. The code is much more readable now.</pre>
<br />
<p>- Jacopo</p>
<br />
<p>On October 15th, 2010, 11:08 a.m., Jacopo De Simoi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs and Olivier Goffart.</div>
<div>By Jacopo De Simoi.</div>
<p style="color: grey;"><i>Updated 2010-10-15 11:08:19</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch allows to specify, for some specific notification contexts, present actions that should be either added or removed with
respect to the default (i.e. without context) ones. E.g. one could write notifyrc files containing:
[Event/someevent/presentation/fullscreen]
Action=-Sound|-Popup
[Event/someevent/quietbutverbose/whatever]
Action=+Popup|-Sound
[Event/someevent/morespecificnotifier/present]
Action=-Popup
This lets the user to customize non-contextualized actions via the usual interface, but at the same time allows some control by the
developer in some particular situations.
The patch changes knotifyconfig.cpp in order to parse contextualized actions also in the system-wide file and includes some basic
validity check in such a way to recognize invalid expressions such as:
Action=-Popup|Sound
I don't know where to document this behaviour; any help on that is most appreciated.
Thanks!</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdebase/runtime/knotify/knotify.cpp <span style="color: grey">(1185812)</span></li>
<li>trunk/KDE/kdebase/runtime/knotify/knotifyconfig.cpp <span style="color: grey">(1185812)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5631/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>