<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5637/">http://svn.reviewboard.kde.org/r/5637/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://svn.reviewboard.kde.org/r/5637/diff/2/?file=39757#file39757line82" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/KDE/kdelibs/kdecore/kernel/kcmdlineargs.h</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">class KDECORE_EXPORT KCmdLineOptions</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">82</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"> * and expect a parameter, like nooption4.</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Better wording:
applies -> apply;
begins -> begin;
like nooption4 -> like "nooption4" in the example below</pre>
</div>
<br />
<p>- David</p>
<br />
<p>On October 19th, 2010, 8:42 p.m., Jaime Torres wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Jaime Torres.</div>
<p style="color: grey;"><i>Updated 2010-10-19 20:42:47</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I need an option called no-label followed by some text.
With this patch, no is not an special prefix if the option needs a parameter.
Also changed the documentation in the header.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">run make test in kdelibs build root, previous results here:
1 - nepomuk-queryparsertest (Failed)
2 - nepomuk-querytest (Failed)
4 - nepomuk-resourcetest (Failed)
11 - kdecore-kstandarddirstest (Failed)
40 - kdecore-kglobaltest (Timeout)
43 - kdecore-kconfigafterkglobaltest1 (Failed)
44 - kdecore-kconfigafterkglobaltest2 (Failed)
45 - kdecore-ktcpsockettest (Failed)
94 - kptyprocesstest (Failed)
96 - kio-krununittest (Failed)
137 - kate-completion_test (Failed)
138 - kate-searchbar_test (Failed)
140 - kate-movingrange_test (Failed)
144 - kate-indenttest (Failed)
no more regressions added by this patch.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdelibs/kdecore/kernel/kcmdlineargs.h <span style="color: grey">(1186814)</span></li>
<li>/trunk/KDE/kdelibs/kdecore/kernel/kcmdlineargs.cpp <span style="color: grey">(1186814)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5637/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>