<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5690/">http://svn.reviewboard.kde.org/r/5690/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You forgot to remove the ontology cmake calls from libs that depend on libnepomuk like libnepomukquery (nepomuk/query/CMakeLists.txt), libnepomukutils (nepomuk/utils/CMakeLists.txt), and the tests (nepomuk/test/CMakeLists.txt)</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://svn.reviewboard.kde.org/r/5690/diff/2/?file=40218#file40218line479" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/KDE/kdelibs/nepomuk/Mainpage.dox</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">479</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">\brief The %Vocabulary namespace contains all classes and methods which can be used to easily access the vocabularies.</pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">"all" is pushing it a bit. Maybe add a hint to onto2vocabularyclass and the cmake macros for using other ontologies. </pre>
</div>
<br />
<p>- Sebastian</p>
<br />
<p>On October 25th, 2010, 2:43 p.m., Vishesh Handa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs and Sebastian Trueg.</div>
<div>By Vishesh Handa.</div>
<p style="color: grey;"><i>Updated 2010-10-25 14:43:09</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This adds a whole lot of Nepomuk/Vocabulary/<file> files, which contain functions for accessing the Vocabularies.
It's a lot easier to just include these files instead of generating them every time we need them ( using soprano_add_ontology ). This would overall reduce the memory footprint and make it easier for developers to use Nepomuk as they don't need to worry about generating classes for the ontologies. Plus, it will make using Nepomuk from some other language ( say Python ) easier as one doesn't have to hard code the ontologies.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested! Works fine.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdelibs/includes/CMakeLists.txt <span style="color: grey">(1187905)</span></li>
<li>/trunk/KDE/kdelibs/includes/Nepomuk/Vocabulary/NCAL <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdelibs/includes/Nepomuk/Vocabulary/NCO <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdelibs/includes/Nepomuk/Vocabulary/NDO <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdelibs/includes/Nepomuk/Vocabulary/NFO <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdelibs/includes/Nepomuk/Vocabulary/NIE <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdelibs/includes/Nepomuk/Vocabulary/NMM <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdelibs/includes/Nepomuk/Vocabulary/NUAO <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdelibs/includes/Nepomuk/Vocabulary/PIMO <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdelibs/nepomuk/CMakeLists.txt <span style="color: grey">(1187905)</span></li>
<li>/trunk/KDE/kdelibs/nepomuk/Mainpage.dox <span style="color: grey">(1187905)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5690/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>