<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5621/">http://svn.reviewboard.kde.org/r/5621/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I see, it's only about having a different "comment" than the default setCaption(i18n("About %1")) in kaboutappdialog itself.
Looks good, please commit.</pre>
<br />
<p>- David</p>
<br />
<p>On October 13th, 2010, 11:03 p.m., Lasse Liehu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Lasse Liehu.</div>
<p style="color: grey;"><i>Updated 2010-10-13 23:03:27</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">So the problem is that in my language (Finnish) we either need to have the application name in elative (e.g. Kate => Katesta, Dolphin => Dolphinista) or do something like "About application %1". Since it's not quite practical to include the elative form for every plugin (through pology&transcript) and "About application %1" would look really out of place, I've made this little patch that would solve this issue in a more elegant way, i.e. to translate "About %1" in this case to something like "About plugin %1".
This is basically doing the same thing as the following does for modules' about dialog/menu entry in systemsettings:
menuItem->setText( i18n( "About %1", menuAbout->programName() ) ); in SettingsBase::changeAboutMenu in kdebase/systemsettings/app/SettingsBase.cpp (at line 392, trunk r1185525)
Is this a good idea?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It compiles and seems to work (not tested with a translation).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdelibs/kutils/kpluginselector.cpp <span style="color: grey">(1185525)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5621/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>