<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5609/">http://svn.reviewboard.kde.org/r/5609/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ah yes, I misread. ok. I see your idea: if the app developer sets this flag and the user does not, then we respect the app's choice.
It just seems unusual that the default value in kdelibs does not exactly match the default value in the KCM, but OK, I don't think Qt would ever change the default value for this, so "true" sounds right as a default-default-value :-)
Green light.</pre>
<br />
<p>- David</p>
<br />
<p>On October 12th, 2010, 4:58 a.m., Christoph Feck wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs and Hugo Pereira Da Costa.</div>
<div>By Christoph Feck.</div>
<p style="color: grey;"><i>Updated 2010-10-12 04:58:51</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The first part of this patch makes the Qt::AA_DontShowIconsInMenus configurable in kdelibs via a KDE config entry.
The second part exposes this config entry in the Styles KCM, just right between the settings to hide icons on buttons or toolbars.
Note that GNOME also has this configuration option.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hiding the menu icons works with all styles (even pure Qt styles), because Qt itself respects this attribute when setting up the menus.
The only "bug" is a missing dialog informing the user that changing this option only affects applications after restarting (same as Xft font settings or locale options). But before I add that, I want some feedback.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=253339">253339</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdebase/workspace/kcontrol/style/finetuning.ui <span style="color: grey">(1184959)</span></li>
<li>/trunk/KDE/kdebase/workspace/kcontrol/style/kcmstyle.cpp <span style="color: grey">(1184959)</span></li>
<li>/trunk/KDE/kdelibs/kdeui/kernel/kglobalsettings.cpp <span style="color: grey">(1184959)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5609/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>