<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5640/">http://svn.reviewboard.kde.org/r/5640/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 17th, 2010, 8:46 a.m., <b>Alexander Neundorf</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You added documentation for KDE4_IMPORTS_INSTALL_DIR, but I didn't see the diff for kdelibs/CreateKDELibsDependenciesFile.cmake here.
This is the file where these variables are written into KDELibsDependencies.cmake, which is then installed and loaded later on when somebody does
find_package(KDE4)
Did I just not find this here on reviewboard, or didn't you put this here, and didn't you do this yet ?
Alex
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">mep, my bad, just forgotten (from just relying on cmake magic to understanding how the magic works takes a while) :D
should be complete now?</pre>
<br />
<p>- Marco</p>
<br />
<p>On October 17th, 2010, 10:02 a.m., Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs, KDE PIM, Pino Toscano, and Alexander Neundorf.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated 2010-10-17 10:02:11</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">since everything installed by KDE should be under its prefix, is not possible to install stuff in the system global Qt imports directory.
define a new variable for the installation to make sure all projects using QML (at the moment Plasma and Kdepim)will install their imports under the same prefix</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdelibs/CreateKDELibsDependenciesFile.cmake <span style="color: grey">(1185165)</span></li>
<li>/trunk/KDE/kdelibs/cmake/modules/FindKDE4Internal.cmake <span style="color: grey">(1185165)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5640/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>