<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5606/">http://svn.reviewboard.kde.org/r/5606/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 11th, 2010, 10:50 p.m., <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This behavior change will result in crashes. See kdebase/apps/konqueror/src/konqbookmarkbar.cpp, where the list of parents (the KBookmarkActionMenus) is deleted before the list of KBookmarkMenus. With this patch, it will result in double-deletion.
Make it a KDE 5 TODO, add a comment in the docu about this being a qobject without a parent, but it can't be fixed.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yep, I just added qDebug() inside constructor and destructor (before reading your comment). When running Konqueror, the BookmarkMenu is created and deleted, when running rekonq, it is only created. So the leak should be worked around in rekonq for now.</pre>
<br />
<p>- Christoph</p>
<br />
<p>On October 11th, 2010, 9:48 p.m., Andrea Diamantini wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Andrea Diamantini.</div>
<p style="color: grey;"><i>Updated 2010-10-11 21:48:02</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think this mini patch should fix a mem leak in kbookmarkmenu, letting its ctor have a parent. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdelibs/kio/bookmarks/kbookmarkmenu.cc <span style="color: grey">(1184934)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5606/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>