<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5536/">http://svn.reviewboard.kde.org/r/5536/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks fine to me, but I am no maintainer.
(My suggestion was to check whether open() was called with the same parameter, but indeed it makes probably even more sense to just raise an error in this condition.)</pre>
<br />
<p>- Hans</p>
<br />
<p>On October 7th, 2010, 7:36 p.m., Boudewijn Rempt wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Boudewijn Rempt.</div>
<p style="color: grey;"><i>Updated 2010-10-07 19:36:50</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It is possible to accidentally call open() twice. If you do that on a zip store, kgzipfilter will be initialized twice, deflateInit2 will be called twice and we leak memory.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdelibs/kdecore/compression/kbzip2filter.cpp <span style="color: grey">(1182756)</span></li>
<li>trunk/KDE/kdelibs/kdecore/compression/kfilterdev.cpp <span style="color: grey">(1182756)</span></li>
<li>trunk/KDE/kdelibs/kdecore/compression/kgzipfilter.cpp <span style="color: grey">(1182756)</span></li>
<li>trunk/KDE/kdelibs/kdecore/compression/kxzfilter.cpp <span style="color: grey">(1182756)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5536/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>