<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5443/">http://svn.reviewboard.kde.org/r/5443/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 29th, 2010, 2:07 a.m., <b>Todd</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What, exactly do the changes do? You say you are making the changes, and you say why you are making them, but as far as I can tell you do not explain what effect your changes have.
I should add that the bug report is for KDE 4.4, the dialog has changed considerably for 4.5, including changes to address the issue brought up with the bug report (that is, clearly labeling which file is overwriting which other file).</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I used the renamedialog.cpp file from trunk, so I have noticed the changes. I quite like the changes myself, and I believe you have made the most recent change yourself.
"What, exactly do the changes do? "
There were two issues in the bug report:
1. The dialog window should not have be blocking all of the dolphin instances (or really anything) - that was fixed in KDE 4.5 I believe.
2. The textbox the user uses to change the name of the file that is being copied/moved was in a confusing place and that if "someone overlooks
the top text" they may end up renaming the wrong file.
#1 was fixed in 4.5. #2, I believe was change for 4.5 or 4.6, but a bit more clarification of the window was needed. See my comment to David below.</pre>
<br />
<p>- Steven</p>
<br />
<p>On September 27th, 2010, 11:05 p.m., Steven Sroka wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Steven Sroka.</div>
<p style="color: grey;"><i>Updated 2010-09-27 23:05:59</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is my first submission to KDE. If I am missing something, don't hesitate to tell me.
This is a slight GUI change to the rename/overwrite dialog window, just to make it more user friendly.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Correctly Compiled.
"Eye ball'ed" Code.
Ran code with all possible '_mode' as per http://api.kde.org/4.5-api/kdelibs-apidocs/kio/html/namespaceKIO.html#bac5df6792cd3426582dbfd1af706bff
Ran many possible combinations (most if not all) -> move folder to folder, file to file, file to folder, folder to file, and paid attention to creation date.
(I actually found a bug with the preview picture that is shown in a certain scenario - I will create a bug notice for it on bugs.kde.org soon)</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=238942">238942</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdelibs/kio/kio/renamedialog.cpp <span style="color: grey">(1179201)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5443/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>