<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5284/">http://svn.reviewboard.kde.org/r/5284/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm wondering; do we need yet-another-plugin for this? Can't e.g. the shorturi filter do it? To minimize the number of plugins that have to be loaded...</pre>
<br />
<p>- David</p>
<br />
<p>On September 7th, 2010, 8:42 p.m., Mark wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Dolphin and kdelibs.</div>
<div>By Mark.</div>
<p style="color: grey;"><i>Updated 2010-09-07 20:42:22</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When a url starts with \\ it can be assumed that the user wants to access a network path. Nothing else starts with \\ anyway.
This patch adds a KUriFilter that converts a windows network path "\\home\path\to\folder" to a samba path "smb://home/path/to/folder".
The filter is added in KUrlNavigator thus all apps that make use of that will be affected.
OK to commit? (since i'm allowed to commit now ^_^)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I tested it on some network shares to access it by the windows path names and it seems to work just fine. No issues so far.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=153347">153347</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdebase/runtime/kurifilter-plugins/CMakeLists.txt <span style="color: grey">(1172686)</span></li>
<li>trunk/KDE/kdebase/runtime/kurifilter-plugins/backwardslashnetworkpath/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdebase/runtime/kurifilter-plugins/backwardslashnetworkpath/bsnpfilter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdebase/runtime/kurifilter-plugins/backwardslashnetworkpath/bsnpfilter.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdebase/runtime/kurifilter-plugins/backwardslashnetworkpath/bsnpfilter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/kfile/kurlnavigator.cpp <span style="color: grey">(1172686)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5284/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>