<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5251/">http://svn.reviewboard.kde.org/r/5251/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="/r/5251/diff/2/?file=35317#file35317line356" style="color: black; font-weight: bold; text-decoration: underline;">trunk/KDE/kdelibs/kio/kio/previewjob.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void PreviewJob::slotResult( KJob *job )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">356</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">d</span><span class="o">-></span><span class="n">currentItem</span><span class="p">.</span><span class="n">item</span><span class="p">.</span><span class="n"><span class="hl">u</span>rl</span><span class="p">().</span><span class="n">isLocalFile</span><span class="p">())</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">356</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">d</span><span class="o">-></span><span class="n">currentItem</span><span class="p">.</span><span class="n">item</span><span class="p">.</span><span class="n"><span class="hl">mostLocalU</span>rl</span><span class="p">().</span><span class="n">isLocalFile</span><span class="p">())</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This should just be item.isLocalFile(), actually.</pre>
</div>
<br />
<p>- David</p>
<br />
<p>On September 6th, 2010, 8:36 p.m., Sebastian Trueg wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Sebastian Trueg.</div>
<p style="color: grey;"><i>Updated 2010-09-06 20:36:22</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently the PreviewJob uses KFileItem::url() to generate the preview for files. However, today targetUrl() is the correct one to use since other hierarchies than the file:/ one can contain local files.
To be precise one would even have to check for UDS_LOCAL_FILE but using targetUrl() is a good start.
Since PreviewJob is a rather big class I would like to have someone look at the patch to check if I missed any url() -> targetUrl() replacement.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=248234">248234</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdelibs/kio/kio/kfileitem.h <span style="color: grey">(1171417)</span></li>
<li>trunk/KDE/kdelibs/kio/kio/kfileitem.cpp <span style="color: grey">(1171417)</span></li>
<li>trunk/KDE/kdelibs/kio/kio/previewjob.cpp <span style="color: grey">(1171417)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5251/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>