<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/758/">http://svn.reviewboard.kde.org/r/758/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Raphael Kubo da Costa.</div>
<p style="color: grey;"><i>Updated 2010-09-05 06:05:06.981290</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Time to revisit this year-old request :)
This patch should now help fix bug 249476: Ark extends KDirSelectDialog and adds a third column to it, but the default size is too narrow and users can only have more free space by resizing the dialog, whereas with this patch it is possible to at least resize the places view width. Another possibility here would be to remove the HBoxLayout and and have the QSplitter as the dialog's main widget, so that the directory list could be resized as well in Ark's use case.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently, there is no way to resize the places view in a KDirSelectDialog. Sometimes the default width is too small, and I can't see the directory names.
Most of the code in this patch was taken from KFileWidget - a QSplitter is inserted between the places view and the directory tree view, its width is read/written using KConfigGroup and it's not automatically resized when the whole dialog is resized.
The drawback is that modifications to code in KFileWidget may require identical modifications to KDirSelectDialog too. Perhaps the best option would be to refactor this functionality somewhere else, but the work required would be much bigger.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Both Ark (in its Extraction Dialog) and Plasma's Desktop Settings (when adding a folder for slideshow wallpapers) now have a QSplitter that works as expected.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=249476">249476</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdelibs/kfile/kdirselectdialog.h <span style="color: grey">(1171225)</span></li>
<li>trunk/KDE/kdelibs/kfile/kdirselectdialog.cpp <span style="color: grey">(1171762)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/758/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>