<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/5160/">http://reviewboard.kde.org/r/5160/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The patch is OK. I see no reason in making this translatable, this is not related to language, but to the current filename, in a way.
If you're renaming "New Folder" (in any western language, at least) you expect "New Folder 1", while if you're renaming "My_Cat_Photo.jpg" you could expect "My_Cat_Photo_1.jpg". This is more about which separator is currently used in the filename, than about languages.
I guess this points to a possible black-magic solution which looks at the current filename, not sure if we want that though.</pre>
<br />
<p>- David</p>
<br />
<p>On August 26th, 2010, 4:24 p.m., Mark wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Dolphin, kdelibs and David Faure.</div>
<div>By Mark.</div>
<p style="color: grey;"><i>Updated 2010-08-26 16:24:37</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I started with this fix because of bug 237022 but it's not fixing that bug. That bug reporter wants a new naming suggestion to look like:
"New_Folder_1"
The current behavior is:
"New Folder_1" (a mixture between spaces and underscore)
And this patch makes it look like:
"New Folder 1" (only spaces)
I however am in favor of using a translatable string so the spacer can be changed by those that translate.. That fix would only mean changing:
const QChar spacer(' ');
to
QString spacer = i18nc("New name suggestion spacer", " ");
The in becomes possible to get suggestions like:
"New_Folder_1" (assuming the "New Folder" name is also changed in the translation files)
It kinda depends on Peter and dfaure which option (translatable or not) is picked.
So, to clarify it. This fix it _not_ fixing bug 237022 but is making it consistent. That bug report (when this patch without translatable line gets accepted) should be closed as "WONTFIX" since it's a special user preference...</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Made the patch, compiled it and tested it by making new files/folders. It seems to work just fine.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=237022">237022</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/tags/KDE/4.5.0/kdelibs/kio/kio/renamedialog.cpp <span style="color: grey">(1168303)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/5160/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>