<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4743/">http://reviewboard.kde.org/r/4743/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm not qualified to review the implementation, but from a design perspective this change is definitely needed once the menubar is supported by a version of Qt that KDE supports. Here is a screen shot that shows the problem:
https://bugs.launchpad.net/ubuntu/+source/plasma-widget-menubar/+bug/618727/+attachment/1493474/+files/appmenu5.png
</pre>
<br />
<p>- Scott</p>
<br />
<p>On July 22nd, 2010, 3:11 p.m., Aurélien Gâteau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs and David Faure.</div>
<div>By Aurélien Gâteau.</div>
<p style="color: grey;"><i>Updated 2010-07-22 15:11:11</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Konqueror shows its throbber in the right corner of its menubar. This is a problem for the "application menu" project I am working on (see http://wiki.ubuntu.com/DesktopExperienceTeam/ApplicationMenu ): custom widgets can't go through DBus.
Attached patch moves it to the toolbar. If there is interest, I could improve on it so that it does not display a button frame when the mouse is moved over it, since clicking it does not trigger any action (this was already the case when it was in the menubar).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- Tested in still and loading mode.
- Verified the throbber resizes itself when the toolbar icon size is changed.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdebase/apps/konqueror/src/konqanimatedlogo.cpp <span style="color: grey">(1147944)</span></li>
<li>trunk/KDE/kdebase/apps/konqueror/src/konqanimatedlogo_p.h <span style="color: grey">(1147944)</span></li>
<li>trunk/KDE/kdebase/apps/konqueror/src/konqmainwindow.cpp <span style="color: grey">(1147944)</span></li>
<li>trunk/KDE/kdebase/apps/konqueror/src/konqueror.rc <span style="color: grey">(1147944)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4743/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>