<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4901/">http://reviewboard.kde.org/r/4901/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ah. I don't know the code, but this sounds good. Feel free to commit if nobody else comments on this patch (not many people working on sonnet afaik).
Would this mechanism also allow to fix bug 244911, where options need to be passed to the filters?</pre>
<br />
<p>- David</p>
<br />
<p>On August 4th, 2010, 1:05 p.m., Michel Ludwig wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Michel Ludwig.</div>
<p style="color: grey;"><i>Updated 2010-08-04 13:05:13</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Recently, the handling of spell checking for upper-case words was fixed in Sonnet::Filter. While this might now work correctly with KTextEdit widgets through Sonnet::Highlighter, although potentially configured differently upper-case words might still be spell checked with Sonnet::BackgroundChecker. This is due to the fact that Sonnet::BackgroundChecker does not possess a way to load or reload specific spell checking configurations.
This patch fixes the problem by adding a 'restore' method to Sonnet::BackgroundChecker, which allows it to read a spell checking configuration and then to pass it on to the filter object that is used internally. The implementation is similar to what is done inside Sonnet::Highlighter.
This patch should also be back-ported to 4.5 eventually.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdelibs/kdecore/sonnet/backgroundchecker.h <span style="color: grey">(1159072)</span></li>
<li>trunk/KDE/kdelibs/kdecore/sonnet/backgroundchecker.cpp <span style="color: grey">(1159072)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4901/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>