<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4897/">http://reviewboard.kde.org/r/4897/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs and David Faure.</div>
<div>By Sebastian Trueg.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">And now for something controversial: A new UDS entry UDS_NEPOMUK_QUERY which contains the serialized query that is used to list that specific folder. I want to use this property to provide faceted browsing of files in all local folders (this includes file:/, nepomuksearch:/, and timeline:/ for now). And I think this part of the patch is not a big deal since it only adds one string value in the UDSEntry. More problematic is the get method in KFileItem since it returns a Nepomuk::Query::Query object and thus, introduces a hard Nepomuk dependency in KIO.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdelibs/kio/kio/kfileitem.h <span style="color: grey">(1159059)</span></li>
<li>trunk/KDE/kdelibs/kio/kio/kfileitem.cpp <span style="color: grey">(1159064)</span></li>
<li>trunk/KDE/kdelibs/kio/kio/udsentry.h <span style="color: grey">(1159059)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4897/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>