<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4966/">http://reviewboard.kde.org/r/4966/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good, thanks!</pre>
<br />
<p>- David</p>
<br />
<p>On August 10th, 2010, 3:43 p.m., Maciej Mrozowski wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs and David Faure.</div>
<div>By Maciej Mrozowski.</div>
<p style="color: grey;"><i>Updated 2010-08-10 15:43:24</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This actually serves as a workaround for application/x-lzma-compressed-tar archives, as for .tar.lzma files KMimeType::findByFileContent returns application/octet-stream with current shared-mime-info. Patch provides fallback - when findByFileContents returns defaultMImeType(), then mimetype is detected from file name instead.
Also David Faure suggested porting mime validation using KMimeType::is (aliases supported) which is done now + a little cleanup.
After patch is done, .tar.xz and .tar.lzma related mimetypes can be added to corresponding kioslaves in runtime/ to finally benefit from xz filter commited in kdelibs-4.4 I think.
--- kioslave/archive/tar.protocol (revision 1161623)
+++ kioslave/archive/tar.protocol (working copy)
@@ -1,7 +1,7 @@
[Protocol]
exec=kio_archive
protocol=tar
-archiveMimetype=application/x-tar,application/x-compressed-tar,application/x-bzip-compressed-tar,application/x-webarchive
+archiveMimetype=application/x-tar,application/x-compressed-tar,application/x-bzip-compressed-tar,application/x-webarchive,application/x-lzma-compressed-tar,application/x-xz-compressed-tar
input=filesystem
output=filesystem
listing=Name,Type,Size,Date,Access,Owner,Group,Link</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Opening .tar.xz, (and now also .tar.lzma is possible) archives using kioslave.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>branches/KDE/4.5/kdelibs/kdecore/io/ktar.cpp <span style="color: grey">(1161667)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4966/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>