<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4939/">http://reviewboard.kde.org/r/4939/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kde-windows and kdelibs.</div>
<div>By andrius.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Implements an extension to kio_file KIOSlave to add a "computer:" protocol. Also reverts changes on "places" panel to show up "Computer" instead of separated drive letters.
I think it would be risky to change the "file:" protocol directly since some apps may try to use "/" and that currently "Just works".
Dolphin's "folders" panel also magically works fine when in "computer:" protocol. When in "file:" it still shows "C:"'s hierarchy only.
Konqueror's sidebar still crashes when using "root" bookmark and not being on "C:". I've also written a patch for that but it still has a bug: can't access a subfolder of a drive without accessing that drive first (an open with... dialog is shown).
(since reviewboard does not accept more than one .diff file it is pasted below)
[on kdebase/apps hierarchy:]
Index: konqueror/sidebar/default_entries/CMakeLists.txt
===================================================================
--- konqueror/sidebar/default_entries/CMakeLists.txt (revision 1151120)
+++ konqueror/sidebar/default_entries/CMakeLists.txt (working copy)
@@ -1,9 +1,25 @@
-install( FILES
- home.desktop
- root.desktop
- bookmarks.desktop
- services.desktop
- remote.desktop
- history.desktop
- places.desktop
-DESTINATION ${DATA_INSTALL_DIR}/konqsidebartng/entries )
+if(WIN32)
+
+ install( FILES
+ home.desktop
+ computer.desktop
+ bookmarks.desktop
+ services.desktop
+ remote.desktop
+ history.desktop
+ places.desktop
+ DESTINATION ${DATA_INSTALL_DIR}/konqsidebartng/entries )
+
+else(WIN32)
+
+ install( FILES
+ home.desktop
+ root.desktop
+ bookmarks.desktop
+ services.desktop
+ remote.desktop
+ history.desktop
+ places.desktop
+ DESTINATION ${DATA_INSTALL_DIR}/konqsidebartng/entries )
+
+endif (WIN32)
\ No newline at end of file
Index: konqueror/sidebar/default_entries/computer.desktop
===================================================================
--- konqueror/sidebar/default_entries/computer.desktop (revision 0)
+++ konqueror/sidebar/default_entries/computer.desktop (revision 0)
@@ -0,0 +1,16 @@
+[Desktop Entry]
+Type=Link
+URL=computer:/
+Icon=computer
+Name=Computer
+Name[en_GB]=Computer
+Name[pt]=Computador
+Name[pt_BR]=Computador
+Comment=This is the place containing the windows drives
+Comment[en_GB]=This is the place containing the windows drives
+Comment[pt]=Este é o local que contém as unidades do windows
+Comment[pt_BR]=Este é o local que contém as unidades do windows
+Open=false
+X-KDE-TreeModule=Directory
+X-KDE-KonqSidebarModule=konqsidebar_tree
+X-KDE-Weight=11
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested using msvc 2008, windows 7</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdelibs/kfile/kfileplacesmodel.cpp <span style="color: grey">(1159835)</span></li>
<li>trunk/KDE/kdelibs/kioslave/file/CMakeLists.txt <span style="color: grey">(1159835)</span></li>
<li>trunk/KDE/kdelibs/kioslave/file/computer.protocol <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/kioslave/file/file.h <span style="color: grey">(1159835)</span></li>
<li>trunk/KDE/kdelibs/kioslave/file/file.cpp <span style="color: grey">(1159835)</span></li>
<li>trunk/KDE/kdelibs/kioslave/file/kio_computer.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/kioslave/file/kio_computer.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4939/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://reviewboard.kde.org/r/4939/s/475/"><img src="http://reviewboard.kde.org/media/uploaded/images/2010/08/08/computer_400x100.png" style="border: 1px black solid;" alt="dolphin screenshot" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>