<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4817/">http://reviewboard.kde.org/r/4817/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="/r/4817/diff/2/?file=32106#file32106line89" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/KDE/kdebase/runtime/kioslave/thumbnail/windowslnkcreator.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool WindowsLnkCreator::create(const QString& path, int width, int height, QImage& img)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">89</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">IcoUtils</span><span class="o">::</span><span class="n">convertExeToIco</span><span class="p">(</span><span class="n">unixFileName</span><span class="p">,</span> <span class="n">icoTempFile</span><span class="p">.</span><span class="n">fileName</span><span class="p">(),</span> <span class="n">iconNumber</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">after IcoUtils::convertExeToIco() call IcoUtils::convertIcoToPng()
IcoUtils::convertIcoToPng() has better conversation from Windows ICO file to PNG. QImage only load first icon from ICO file, but ICO file can has more then one icon (with higher resolution). And then do not use QImage::scaled(). You can specify size of icon in IcoUtils::convertIcoToPng().
See windowsexecreator.cpp</pre>
</div>
<br />
<p>- Pali</p>
<br />
<p>On August 2nd, 2010, 10:45 a.m., Nicholas van Oudtshoorn wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Nicholas van Oudtshoorn.</div>
<p style="color: grey;"><i>Updated 2010-08-02 10:45:24</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch implements thumbnailing support for Microsoft Windows link files (.lnk) via the thumbnail kioslave
It uses the external application "winepath" - part of the wine package (www.winehq.org) to translate windows paths to their unix equivalents. If said path (or indeed the winepath application) doesn't exist, no thumbnail is drawn.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works for me!</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdebase/runtime/kioslave/thumbnail/windowslnkthumbnail.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdebase/runtime/kioslave/thumbnail/icoutils.h <span style="color: grey">(1158174)</span></li>
<li>/trunk/KDE/kdebase/runtime/kioslave/thumbnail/icoutils.cpp <span style="color: grey">(1158174)</span></li>
<li>/trunk/KDE/kdebase/runtime/kioslave/thumbnail/windowslnkcreator.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdebase/runtime/kioslave/thumbnail/windowslnkcreator.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdebase/runtime/kioslave/thumbnail/CMakeLists.txt <span style="color: grey">(1158174)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4817/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>