<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4773/">http://reviewboard.kde.org/r/4773/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Pedro Lopez-Cabanillas.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">Compiling any class inherited from KMediaPlayer::Player, gcc reports this warning:
/usr/include/kxmlguiclient.h:326: warning: ‘virtual void
KXMLGUIClient::stateChanged(const QString&,
KXMLGUIClient::ReverseStateChange)’ was hidden
/usr/include/KDE/KMediaPlayer/../../kmediaplayer/player.h:131: warning:
by ‘void KMediaPlayer::Player::stateChanged(int)’
KParts::Part inherits from XMLGUIClient the stateChanged(const QString&,...) method, and KMediaPlayer::Player::stateChanged(int) is a signal.
The problem is that hiding the method stateChanged(QString&) prevents the KPart to be able to use XMLGUI states.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">Olivier Goffart provided a solution in k-c-d:
The 'workaround' is to explicitly hide or enable it back with the 'using'
keyword
put
using KXMLGUIClient::stateChanged;
in the protected section of the KMediaPlayer::Player class
this does not break BC
I've confirmed that this solution works, and didn't detect any breakage.
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=246130">246130</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdelibs/interfaces/kmediaplayer/player.h <span style="color: grey">(1156320)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4773/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>