<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN" "http://www.w3.org/TR/REC-html40/strict.dtd"><html><head><meta name="qrichtext" content="1" /><style type="text/css">p, li { white-space: pre-wrap; }</style></head><body style=" font-family:'Segoe'; font-size:9pt; font-weight:400; font-style:normal;">The mail entered my inbox /today/ and i couldn't find an entry in the kcd archive, so comments after a rough scan:<br>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><br></p>1. i guess implementing classes in a header is an absolute no-go :-(<br>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><br></p>2. addMenu() does not transfer onership, i.e. w/o actually seeing the patch applied i just assume your websearch popup doesn't get deleted anywhere, but probably created on each rmb -> leaks?!<br>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><br></p>3. QActions can query a QVariant data, so by binding the menu's truggered(QAction*) signal to your slot and (in case you need/want to get really sure) asking for sender() you can probably omit the SearchAction<br>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><br></p>4. though using blanks and brackets in klineedit.cpp seems to be not entirely consistent, there's certainly a blank between a keyword (if, for) and the opening bracket<br>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><br></p>Thomas<br>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><br></p><p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><br></p>Am Saturday 23 May 2009 schrieb Sebastian Tilsch:<br>
> Hello,<br>
> this is my first attempt in developing for the KDE project ( except my own<br>
> programs). I added a small but useful feature, that I would like to see in<br>
> most of the components, where text is selectable.<br>
> It expands the context menu of a KLineEdit with the feature "search in<br>
> web...". It uses the current user configuration of Search Providers, which<br>
> is accessible with "kcmshell4 ebrowsing", but it will only use the user<br>
> chosen favorite ones.<br>
> It would be even more useful in other components, like the KRichTextEdit,<br>
> KRichTextWidget, selectable Labels (unfortunately all applications use the<br>
> native QLabel) and in programs, like konsole and konqueror.<br>
> I know from the KDE4.3 release Schedule that adding features for this<br>
> release is over, but maybe, if someone else has the opinion too, this handy<br>
> little feature could be useful, we could still integrate it. Than I would<br>
> also go on, adding it to the other components, as mentioned before.<br>
> I hope the position of the extra classes in "klineedit_p.h" is correct (of<br>
> course, only as long as it is not used by other control-elements).<br>
> The patch I attached modifies klineedit_p.h and klineedit.cpp<br>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><br></p><p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><br></p></body></html>