<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN" "http://www.w3.org/TR/REC-html40/strict.dtd"><html><head><meta name="qrichtext" content="1" /><style type="text/css">p, li { white-space: pre-wrap; }</style></head><body style=" font-family:'Consolas'; font-size:11pt; font-weight:400; font-style:normal;">On Wednesday 18 February 2009, Michael Pyne wrote:<br>
> Standing by for comments (although it will be some hours before I'm online<br>
> again most likely).<br>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><br></p>So far I have the outstanding request to call i18n() only once in the event of an error which I still need to change.<br>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><br></p>I've been working on KRun today (in kio) based on some discussion on IRC with dfaure as to where best to add the feature to make a file executable. My current work is attached as 2 patches. It compiles but is untested as I need to be awake in 6 hours for work.<br>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><br></p>First patch is against kdecore's KDesktopFile to make the isAuthorizedDesktopFile static method reflect the criteria used in my first patch against klauncher in addition to Kiosk (which means I will probably alter my first patch to simply call KDesktopFile::isAuthorizedDesktopFile), since this code is used by KRun and was already mostly identical. KDesktopFile::isAuthorizedDesktopFile used to always allow desktop files on the user's Desktop, which is what we're trying to avoid now.... ;)<br>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><br></p>The second patch (fix-desktop-file-security-2) adds the ability to make the file executable and continue automatically (if the reason execution was forbidden wasn't due to Kiosk, that is). I'm using a KMessageBox with a details button. I think the text is kind of clumsy but I'm very tired right now and can't think of anything better. :)<br>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><br></p>Again, I haven't been able to test yet, if someone does make a KRun testcase I'd appreciate screenshots so we can see what it look like, otherwise I will do so tomorrow when I get off of work and doing chores from my wife. ;)<br>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><br></p>Still missing is actually tying all of this into the file view used by Konq, Dolphin, and Folder View, which all still ends up in klauncher since I apparently have not covered all the possibilities in KRun. But I'd appreciate feedback on what I've got so far.<br>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><br></p>Regards,<br>
- Michael Pyne</p></body></html>