<br><br><div><span class="gmail_quote">On 10/28/07, <b class="gmail_sendername">Oswald Buddenhagen</b> <<a href="mailto:ossi@kde.org">ossi@kde.org</a>> wrote:</span><blockquote class="gmail_quote" style="margin:0;margin-left:0.8ex;border-left:1px #ccc solid;padding-left:1ex">
please teach your mailer to attach patches as text not binary.</blockquote><div><br class="webkit-block-placeholder"></div><div>sorry, gmail does what it wants</div><br><blockquote class="gmail_quote" style="margin:0;margin-left:0.8ex;border-left:1px #ccc solid;padding-left:1ex">
On Sat, Oct 27, 2007 at 05:07:10PM -0500, Thomas Braxton wrote:<br>> 1) do we want to support an empty group name? We've never supported it<br>> before, and I really don't see a use for it, but it shouldn't be too hard to
<br>> add support for.<br>> 1a) If we do, do we want to support empty sub-group names?<br>> 2) this one depends on #1, should the name of the default group be exposed?<br>> It's really just an implementation detail that I think should never be
<br>> returned to the user, unless we decide to support empty group names.<br>><br>the concept of giving the root group a virtual name is bogus. it should<br>be a null string. we planned to eliminate this <default> madness - a
<br>list of all(?) occurrences can be found here:<br><a href="http://web.davidfaure.fr/kde/default.list">http://web.davidfaure.fr/kde/default.list</a> - wanna go ahead with it?<br>this, btw, does not mean that the name of the root group is "" - the
<br>root group simply has no name, but we need to address it somehow through<br>our tree-wise inferior api. consequently, subgroups cannot have empty<br>names, either.</blockquote><div><br class="webkit-block-placeholder">
</div><div>A couple of problems with what you wrote:</div><div>1) A group with an empty name does not have to be the <default> group, it would be written to an ini file as [].</div><div>2) The unnamed <default> group is written to the ini file without a group marker at all. The other toplevel groups are siblings not children of the unnamed <default> group, so there is no *root* group.
</div><div><br> </div><div>I was referring to this thread <span class="Apple-style-span" style="font-family: 'Lucida Grande'; font-size: 12px; white-space: pre; "><a href="http://lists.kde.org/?l=kde-core-devel&m=119151900709470&w=2">
http://lists.kde.org/?l=kde-core-devel&m=119151900709470&w=2</a><span class="Apple-style-span" style="font-family: arial; font-size: 13px; white-space: normal; "></span></span></div><div><span class="Apple-style-span" style="font-family: 'Lucida Grande'; font-size: 12px; white-space: pre; ">
<span class="Apple-style-span" style="font-family: arial; font-size: 13px; white-space: normal; ">So do we want to support "[]"? If yes, then what should be returned as the name of the <default> group? QByteArray()? If not, then why not use the name ""?
</span></span></div><div><br> </div><blockquote class="gmail_quote" style="margin:0;margin-left:0.8ex;border-left:1px #ccc solid;padding-left:1ex">> 3) should the translated entries from other locales be removed from the
<br>> entryMap?<br>><br>yes<br><br>> Index: kconfig.cpp<br>> ===================================================================<br>> --- kconfig.cpp (revision 730036)<br>> +++ kconfig.cpp (working copy)
<br>> @@ -520,7 +520,9 @@<br>> bool KConfig::isGroupImmutableImpl(const QByteArray& aGroup) const<br>> {<br>> Q_D(const KConfig);<br>> - return isImmutable()|d->entryMap.getEntryOption(aGroup, 0, 0, KEntryMap::EntryImmutable);
<br>> + if (aGroup.isEmpty())<br>> + return d->bFileImmutable;<br>> + return d->bFileImmutable|d->entryMap.getEntryOption(aGroup, 0, 0, KEntryMap::EntryImmutable);<br>> }<br>><br>this looks bogus. it should be possible to have an empty group with
<br>an immutability marker. fix the entry map if it doesn't work.</blockquote><div><br> </div><div>the <default> group is immutable if the file is immutable, since it doesn't have it's own group marker in the file, but then if you want to support [], then you're right the "" group will have it's own immutability marker.
</div><br><blockquote class="gmail_quote" style="margin:0;margin-left:0.8ex;border-left:1px #ccc solid;padding-left:1ex">> Index: kconfiggroup.cpp<br>> ===================================================================
<br>> --- kconfiggroup.cpp (revision 730036)<br>> +++ kconfiggroup.cpp (working copy)<br>> @@ -1096,7 +1129,6 @@<br>> {<br>> writePathEntry(pKey.toUtf8(), path, pFlags);<br>> }<br>> -<br>> void KConfigGroup::writePathEntry(const char *pKey, const QString & path, WriteConfigFlags pFlags)
<br>> {<br>> writePathEntry(QByteArray(pKey), path, pFlags);<br>><br>not good. ;)</blockquote><div><br class="webkit-block-placeholder"></div><div>oops </div><br><blockquote class="gmail_quote" style="margin:0;margin-left:0.8ex;border-left:1px #ccc solid;padding-left:1ex">
the rest seems ok to me.<br><br>--<br>Hi! I'm a .signature virus! Copy me into your ~/.signature, please!<br><br>--<br>Chaos, panic, and disorder - my work here is done.<br></blockquote></div><br>