Hi all,<br><br>I have everything compiling and working. The ppatch is only for the kdelibs/kdeui/icons folder diff, the rest of the
commits are for adaptation from K3Icon:: to KIconLoader:: and similars.<br><br>You can find it on: <a href="http://media.ereslibre.es/2007/10/kdelibs-kdeui-icons.diff">http://media.ereslibre.es/2007/10/kdelibs-kdeui-icons.diff
</a><br><br>What needs to be explained is that K3Icon contained some information, but almost always the stuff was used like:
<br><br>if (icon.isValid())<br> doSomethingWith(icon.path);<br><br>So,
now, when we were returning a K3Icon, we return a QString. When this
string is null (QString()) is like the icon wasn't valid, and when this
string is not null, it contains the path of the icon.
<br><br>Please review some magic changes done at
KIconLoader::loadIcon(). I think I've done correctly but I'd like
someone familiar with this code to double check it. Specially:<br><br> // No? load it.<br>
- K3Icon icon;<br>+ QString icon;<br> if (absolutePath && !favIconOverlay)<br> {<br>- icon.context=K3Icon::Any;<br>- icon.type=K3Icon::Scalable;<br>-
icon.path=name;<br>+ iconType=Scalable;<br>+ icon=name;<br> }<br><br>and<br><br>- iconType = icon.type;<br>- iconThreshold = icon.threshold;<br>- path = icon.path;<br>+ iconThreshold = 0;
<br>+ path = icon;<br><br>I haven't ever seen iconThreshold being changed...