Ruqola in KDE-review

[laurent Montel]

Le lundi 16 septembre 2019, 23:01:56 CEST Albert Astals Cid a écrit :
> El dilluns, 16 de setembre de 2019, a les 6:54:40 CEST, laurent Montel va 
escriure:
> > Le dimanche 15 septembre 2019, 23:54:19 CEST Albert Astals Cid a écrit :
> > > El dijous, 12 de setembre de 2019, a les 9:20:45 CEST, laurent Montel va
> > 
> > escriure:
> > > > Hi,
> > > > I would like to move ruqola to extragear/network.
> > > > So I asked to sysadmin to move ruqola to kde-review (it was done).
> > > > 
> > > > Ben told me that this period will start in 2 weeks.
> > > > 
> > > > If you want to review it... :)
> > > 
> > > class LIBRUQOLACORE_TESTS_EXPORT Emoji
> > > has
> > > Emoji &operator=(const Emoji &other);
> > > but no
> > > Emoji(const Emoji &other);
> > > 
> > > newer gcc complains about it, also the operator= doesn't copy
> > > mCachedHtml is that on purpose? If not i'd suggest to simply mark
> > > operator= and the copy contructor as = default.
> > > 
> > > 
> > > 
> > > 
> > > class LIBRUQOLACORE_TESTS_EXPORT User
> > > also has the same warning, given that the operator= is implemented and
> > > not
> > > the copy constructor. Same suggestion to just use = default on them.
> > > 
> > > 
> > > and a whole lots more of classes seem to have this issue. Can you double
> > > check them for me?
> > 
> > Fixed thanks
> 
> Awesome, i think i may have forgotten to paste 2 more (the warning log was
> very long)
> 
> http://paste.debian.net/1101123/

Fixed thanks

> Cheers,
>   Albert
> 
> > > http://paste.debian.net/1100950/
> > > 
> > > Cheers,
> > > 
> > >   Albert
> > >   
> > > > Regards.


-- 
Laurent Montel | laurent.montel at kdab.com | KDE/Qt Senior Software Engineer 
KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, 
 www.kdab.fr KDAB - The Qt, C++ and OpenGL Experts - Platform-independent 
software solutions