Ruqola in KDE-review

[laurent Montel]

Le lundi 16 septembre 2019, 00:14:12 CEST Albert Astals Cid a écrit :
> El dijous, 12 de setembre de 2019, a les 9:20:45 CEST, laurent Montel va 
escriure:
> > Hi,
> > I would like to move ruqola to extragear/network.
> > So I asked to sysadmin to move ruqola to kde-review (it was done).
> > 
> > Ben told me that this period will start in 2 weeks.
> > 
> > If you want to review it... :)
> 
> Now onto the using side:
> 
> Starting it for the first time says
> 
> received something unhandled: "{\"server_id\":\"0\"}"
> Connected
> org.kde.ruqola: Unknown service type:  "Accounts_OAuth_Gitlab_identity_path"
> org.kde.rocketchatqtrestapi: Auth settings is empty. It's a bug
> org.kde.rocketchatqtrestapi: Impossible to start GetSupportedLanguagesJob
> org.kde.rocketchatqtrestapi: Impossible to start GetSupportedLanguagesJob

Normal it's a bug from yesterday. This one will be fixed today.


> 
> And then the ui says "login failed"
> 
> 
> Connected to what? Is it attempting to login to something even if i have
> never used the app?

Yep on open.rocket.chat server. It's the default server. Perhaps I need to 
disable it.

> Maybe we should not try to do that? it's a bit
> confusing
> 
> Can the icons on the top bar have tooltips? I had no idea what would happen
> when pressing the "two people" icon.

I will add tooltips on theses icons.

> 
> Quite a few of the "default avatars" (i.e. those that don't have their own
> avatar set) look small and wrong if you compare them to what they look on
> the webapp (see your company chat for an example)

Yep known bug. For the moment I don't understand why.

> 
> Configure account is unfinished? https://i.imgur.com/d8wUwNn.png

Yep it's in progress.

> Ah, on the second login looked different and it at least showed my account
> name there on the first line (even though i still was not able to configure
> anything?)
> 
> Searching for "montel" on the webapp on the company server shows me your
> chat (that i don't have open), searching for the same on ruqola doesn't, so
> i don't really have a way to talking to you

Where do you search it ?

> 
> Also some of the fonts look terrible for a chat app, but that may be because
> of Qt Quick itself :/

I know it. For the moment no idea about this bug too

> 
> Compare https://i.imgur.com/d4sKAwn.png (ruqola) with
> https://i.imgur.com/ibZ7Uim.png (kmail)
> 
> Other than that it seems that it is a good start, so i agree it's a good
> idea to make some noise around it and see if we can get some more
> contributors :)
> 
> Cheers,
>   Albert
> 
> > Regards.


-- 
Laurent Montel | laurent.montel at kdab.com | KDE/Qt Senior Software Engineer 
KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, 
 www.kdab.fr KDAB - The Qt, C++ and OpenGL Experts - Platform-independent 
software solutions