Review Request 125227: Don't create new symlinks when copying symlinks - copy the file's contents - like /usr/bin/cp

Shlomi Fish shlomif at iglu.org.il
Mon Sep 14 19:50:07 BST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125227/
-----------------------------------------------------------

Review request for kdelibs.


Repository: kio


Description
-------

This patch copies the symlinked file's contents upon a copy - like /usr/bin/cp instead of creating a new symlink. This is an attempt to fix https://bugs.kde.org/show_bug.cgi?id=315482 and https://bugs.kde.org/show_bug.cgi?id=335808 which were reported in gwenview and was done per consensus in an IRC discussion on #kde-devel on freenode.


Diffs
-----

  src/core/copyjob.cpp b0d054a 

Diff: https://git.reviewboard.kde.org/r/125227/diff/


Testing
-------

Tested briefly with gwenview on Mageia Linux x86-64 6.


Thanks,

Shlomi Fish

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20150914/1b4295b2/attachment.htm>


More information about the kde-core-devel mailing list