Moving KFIleMetadata into KDE SC (documentation and ExtractionResult)

[Albert Astals Cid]

El Divendres, 17 de gener de 2014, a les 18:03:31, Vishesh Handa va escriure:
> Hey guys
> 
> I should have posted this with the Baloo thread, but since I did not -
> 
> WIth KDE SC 4.10, Nepomuk dropped support for Strigi and implemented their
> own indexing library. This code was part of nepomuk-core. With Baloo, this
> code has been migrated into its own repository called kfilemetadata. I'm
> hoping to make it into its own framework some point in the future.
> 
> I would like to move this code into KDE SC along with Baloo.
> 
> None of the code is new. It has all been taken from neopmuk-core. The only
> change is that the indexers no longer use the ontologies.

Can you have a look at 
    virtual void extract(ExtractionResult* result) = 0;
It seems to me that the documentation is wrong, it lists lots of params.

Also i tried looking at ExtractionResult and without documentation i'm not 
sure i'd be able to use it, could you add some docu and/or example?

Also I was wondering what is if we could move from all those strings to enums?

I mean
  result->add("copyright", it.value());
is a bit hard, since whatever reads the result has to know it has to query for 
"copyright".

Also i am wondering why addType is virtual and append/add are pure virtual.

Cheers,
  Albert

> 
> --
> Vishesh Handa