Review Request 114454: kjs: Implement ES6 Math.hypot

Bernd Buschinski b.buschinski at googlemail.com
Thu Jan 16 17:56:30 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114454/
-----------------------------------------------------------

(Updated Jan. 16, 2014, 5:56 p.m.)


Status
------

This change has been marked as submitted.


Review request for kdelibs.


Repository: kdelibs


Description
-------

kjs: Implement ES6 Math.hypot

I agree that the loop, that is just checking for Inf looks weird, but thats what the spec says.
We MUST check everything first for Inf, NaN checks must come later.

So a (1, NaN, Inf) must return Inf.


Diffs
-----

  kjs/math_object.h 3d193dd 
  kjs/math_object.cpp 89835e5 

Diff: https://git.reviewboard.kde.org/r/114454/diff/


Testing
-------


Thanks,

Bernd Buschinski

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140116/36aa24cc/attachment.htm>


More information about the kde-core-devel mailing list