Review Request 114907: Make KFontUtils::adaptFontSize be a bit more exact

Andrea Iacovitti aiacovitti at libero.it
Wed Jan 8 07:10:31 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114907/#review47019
-----------------------------------------------------------



kdeui/fonts/kfontutils.cpp
<https://git.reviewboard.kde.org/r/114907/#comment33529>

    typo: if if -> if it


- Andrea Iacovitti


On Jan. 7, 2014, 10:36 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114907/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2014, 10:36 p.m.)
> 
> 
> Review request for kdelibs and Jeremy Whiting.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Not all fonts are linear in drawn size against their point size, the old code assumes so and simply guesses the next font size taking into account the pointSize we drawn, the geometry we got and the geometry we want. The new code is a bit slower but will make sure that we get better pointSize results in non linear fonts.
> 
> 
> Diffs
> -----
> 
>   kdeui/fonts/kfontutils.cpp 3a80039 
> 
> Diff: https://git.reviewboard.kde.org/r/114907/diff/
> 
> 
> Testing
> -------
> 
> Blinken still works. Font sizes are similar.
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140108/2ca8a400/attachment.htm>


More information about the kde-core-devel mailing list