Review Request 110084: Make ftp error messages prettier

Kai Uwe Broulik kde at privat.broulik.de
Tue May 7 08:48:27 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110084/
-----------------------------------------------------------

(Updated May 7, 2013, 7:48 a.m.)


Review request for kdelibs and David Faure.


Changes
-------

Add "Error" to message, since FTP error messages returned by the server always(?) start with the error number.

Now it says:
Could not connect to host ftp.example.com (Error 421 Too many connections (5) from this IP).


Description
-------

Remove linebreaks and trim the message so the ugly linebreak at the end disappears.


This addresses bug 318079.
    http://bugs.kde.org/show_bug.cgi?id=318079


Diffs (updated)
-----

  kioslave/ftp/ftp.cpp b0868d8 

Diff: http://git.reviewboard.kde.org/r/110084/diff/


Testing
-------

Works and looks much nicer :)


File Attachments
----------------

Before
  http://git.reviewboard.kde.org/media/uploaded/files/2013/04/19/ftpmessagebefore.png
After
  http://git.reviewboard.kde.org/media/uploaded/files/2013/04/19/ftpmsgafter.png


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130507/16fd4542/attachment.htm>


More information about the kde-core-devel mailing list