Review Request 111115: Handle ramfs mounts correctly so copying files to them works

Commit Hook null at kde.org
Fri Jun 21 22:46:04 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111115/#review34841
-----------------------------------------------------------


This review has been submitted with commit af114cc90c4767012923d6d3901c6fbf7b813ea2 by Dawit Alemayehu to branch master.

- Commit Hook


On June 21, 2013, 1:21 a.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111115/
> -----------------------------------------------------------
> 
> (Updated June 21, 2013, 1:21 a.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Description
> -------
> 
> The attached patch adds RAMFS_MAGIC value to KFileSystemType so that KIO::CopyJob would not try to determine the available size on such mounts. Otherwise, the available size reported back will be zero (not correct) and KIO::CopyJob will fail with a disk full error.
> 
> 
> This addresses bug 299156.
>     http://bugs.kde.org/show_bug.cgi?id=299156
> 
> 
> Diffs
> -----
> 
>   kdecore/io/kfilesystemtype_p.h 3194329 
>   kdecore/io/kfilesystemtype_p.cpp 23f8002 
>   kio/kio/copyjob.cpp 1c23e8e 
> 
> Diff: http://git.reviewboard.kde.org/r/111115/diff/
> 
> 
> Testing
> -------
> 
> Mount RAMDISK as outlined in the bug report and attempt to copy file before and after the patch.
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130621/c1139db6/attachment.htm>


More information about the kde-core-devel mailing list