Review Request: Don't add qml elements twice to the scene, reduce warnings

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108079/#review24434
-----------------------------------------------------------

Ship it!


Ship It!

- Marco Martin


On Jan. 2, 2013, 2:20 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108079/
> -----------------------------------------------------------
> 
> (Updated Jan. 2, 2013, 2:20 p.m.)
> 
> 
> Review request for kdelibs, Plasma and Marco Martin.
> 
> 
> Description
> -------
> 
> don't addItem to the scene after calling setParentItem. It's redundant according to the api documentation and removes a warning.
> 
> 
> Diffs
> -----
> 
>   plasma/widgets/declarativewidget.cpp 81f09c3 
> 
> Diff: http://git.reviewboard.kde.org/r/108079/diff/
> 
> 
> Testing
> -------
> 
> Ran some plasmoids, works fine.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130102/b1f8096b/attachment.htm>
-------------- next part --------------
_______________________________________________
Plasma-devel mailing list
Plasma-devel at kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel