Review Request: Pass decorationSize to QStyleOptionView in KWidgetItemDelegatePrivate

Christoph Feck christoph at maxiom.de
Sun Mar 18 01:59:20 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104322/#review11514
-----------------------------------------------------------


Hm, having to "patch" this at multiple locations makes me believe there should be a helper function, even if inline, that does all the option setup?

- Christoph Feck


On March 18, 2012, 1:44 a.m., Daniele Elmo Domenichelli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104322/
> -----------------------------------------------------------
> 
> (Updated March 18, 2012, 1:44 a.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> Pass decorationSize to QStyleOptionView in KWidgetItemDelegatePrivate
> 
> 
> Diffs
> -----
> 
>   kdeui/itemviews/kwidgetitemdelegate.cpp 4378e417af2469bb52896648cce70bc523a07a16 
> 
> Diff: http://git.reviewboard.kde.org/r/104322/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniele Elmo Domenichelli
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120318/2a6c1372/attachment.htm>


More information about the kde-core-devel mailing list