Review Request: Test also the prefix value

Frank Reininghaus frank78ac at googlemail.com
Sat Mar 3 13:05:37 GMT 2012


Hi,

Am 27. Februar 2012 17:36 schrieb Commit Hook:
> This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104068/
>
> This review has been submitted with commit 6e0d694b302b57883ed79a3b47c9d60bea20dc8e by Mario Bensi to branch KDE/4.8.

The new unit test which you included in this commit fails for me
because the owner of a file in the archive does not match the
expectation:

FAIL!  : KArchiveTest::testTarDirectoryForgotten() Compared values are
not the same
   Actual (listing[ 9]): mode=40777 user=kde-4.8 group=users
path=Test/qt-jambi-qtjambi-4_7/examples/generator/trolltech_original/java/com/trolltech/examples/generator
type=dir
   Expected (QString("mode=40777 user=nef group=users
path=Test/qt-jambi-qtjambi-4_7/examples/generator/trolltech_original/java/com/trolltech/examples/generator
type=dir")): mode=40777 user=nef group=users
path=Test/qt-jambi-qtjambi-4_7/examples/generator/trolltech_original/java/com/trolltech/examples/generator
type=dir
   Loc: [/home/kde-4.8/kde/src/KDE/kdelibs/kdecore/tests/karchivetest.cpp(629)]

It looks like I'm not the only one getting this failure:

http://my.cdash.org/testDetails.php?test=8836261&build=305462
http://build.kde.org/job/kdelibs_KDE-4.8/265/testReport/%28root%29/TestSuite/kdecore_karchivetest/

Could you have a look at that issue?

Thanks,
Frank




More information about the kde-core-devel mailing list