Review Request: Fix readLongLink method

Kevin Ottens ervin at kde.org
Mon Feb 27 08:02:19 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104062/#review10938
-----------------------------------------------------------

Ship it!


Just like David with your previous request I don't necessarily have the fine knowledge of tarball structure. But this patch looks sane, if it helps supporting more files, go for it.

- Kevin Ottens


On Feb. 24, 2012, 5:22 p.m., Mario Bensi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104062/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2012, 5:22 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Description
> -------
> 
> We need to skip the value also when the skip are equal to 0x200
> otherwise the value of the next buffer is dirty, is beginning with the
> end of the last buffer and if the skip are equal to 0x200 the first byte
> of the next buffer is 0 and if we find 0 at the first place we stop the
> process.
> 
> 
> Diffs
> -----
> 
>   kdecore/io/ktar.cpp 9c3a010 
>   kdecore/tests/karchivetest.cpp 6eab645 
> 
> Diff: http://git.reviewboard.kde.org/r/104062/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mario Bensi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120227/ea217c06/attachment.htm>


More information about the kde-core-devel mailing list