Review Request: Fix hang in kcm_useraccount

[Oswald Buddenhagen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105895/#review17428
-----------------------------------------------------------


heh - nasty: you put the dialog invocation into the backend class. to be consistent, you'd need to put the error message boxes into that class as well, and thus kill all core/gui separation entirely. ^^
but you hit the nail exactly on the head: the kdesu framework needs to be callback-based instead of requiring a password a-priori. i think the most qt way to do that would be the class emitting a needAuthentication(qstring prompt) signal and awaiting a returnAuthentication(qstring pw) slot invocation in return. the alternative would be handler classes with virtual functions (see kgreeter.h somewhere in workspace).
do you feel like doing it right (and thus providing a prototype for the new kdesu) or want to take the shortcut?


- Oswald Buddenhagen


On Aug. 14, 2012, 12:33 p.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105895/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2012, 12:33 p.m.)
> 
> 
> Review request for KDE Base Apps.
> 
> 
> Description
> -------
> 
> When changing the user's full name, chfn may not necessarily produce any output. Since readLine blocks, the kcm may hang.
> 
> This change checks if chfn exited without output, and if so, use that exit status.
> 
> 
> This addresses bug 156396.
>     http://bugs.kde.org/show_bug.cgi?id=156396
> 
> 
> Diffs
> -----
> 
>   kdepasswd/kcm/chfnprocess.h c9f0700f51d0a749b43c75840c43b46ccadb538a 
>   kdepasswd/kcm/chfnprocess.cpp 9f75d4aa75b41acec84e7798c789d4226ca3fab9 
>   kdepasswd/kcm/main.cpp 5a5248e545cc75433024ae0464ac9f3e05b71900 
> 
> Diff: http://git.reviewboard.kde.org/r/105895/diff/
> 
> 
> Testing
> -------
> 
> Tested all combinations of password required and name change permitted, with success.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120815/1f7f797d/attachment.htm>