Review Request: kjs: Use toPrimitive in Array.join to get the correct String

Bernd Buschinski b.buschinski at googlemail.com
Thu Aug 2 16:36:17 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105391/
-----------------------------------------------------------

(Updated Aug. 2, 2012, 3:36 p.m.)


Review request for kdelibs.


Changes
-------

killed the superfluous if (element->isObject())  as well


Description
-------

kjs: Use toPrimitive in Array.join to get the correct String

the default value case for String is present here, as testcase S15.4.4.5_A3.2_T2 shows


Diffs (updated)
-----

  kjs/array_object.cpp 0da29b0 

Diff: http://git.reviewboard.kde.org/r/105391/diff/


Testing
-------


Thanks,

Bernd Buschinski

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120802/775ffcd0/attachment.htm>


More information about the kde-core-devel mailing list