Review Request: Allow use of shift together with multimedia keys in shortcuts

[Michael Jansen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101530/#review3753
-----------------------------------------------------------

Ship it!


I think that looks good. 

- Michael


On June 7, 2011, 7:21 a.m., Simon Persson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101530/
> -----------------------------------------------------------
> 
> (Updated June 7, 2011, 7:21 a.m.)
> 
> 
> Review request for kdelibs and Michael Jansen.
> 
> 
> Summary
> -------
> 
> Make this beautiful piece of code even more beautiful! The proper fix would be to add platform-specific functions to check if shift changes the symbol produced when the key is pressed, but that will have to wait.
> 
> 
> This addresses bug 184195.
>     http://bugs.kde.org/show_bug.cgi?id=184195
> 
> 
> Diffs
> -----
> 
>   kdeui/widgets/kkeysequencewidget.cpp a35c2b4 
> 
> Diff: http://git.reviewboard.kde.org/r/101530/diff
> 
> 
> Testing
> -------
> 
> Not tested.
> 
> 
> Thanks,
> 
> Simon
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110607/602bf213/attachment.htm>